On Wed, 12 Nov 2025 16:57:16 GMT, Andy Goryachev <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> debug fix
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 212:
>
>> 210:
>> 211: private static void debug_println(String str) {
>> 212: if (DEBUG) {
>
> I am sorry, I was not sufficiently clear.
> This method does not need the conditional. The conditionals are needed in
> **every** place that calls here.
> In other words, we don't want to incur the string concatenation overhead if
> **DEBUG** is false.
will that be too much overhead? We had used the same in jdk having DEBUG check
in one place...but I will modify it for FX..
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1968#discussion_r2521089549
