Re: RFR: 8250802: Refactor StringConverter and its subclasses [v2]

[Nir Lisker]

On Wed, 19 Nov 2025 15:38:44 GMT, Andy Goryachev <ango...@openjdk.org> wrote:

>> Why would it? It was the same before this change?
>
> Not exactly, if I read it right.
> The lenient flag is not set if the format is specified in the constructor - 
> see L204 in the original class.  The new code clears this flag regardless.

Maybe I'm missing something. The constructor that takes a `DateFormat` directly 
in the new code is

    public DateTimeStringConverter(DateFormat dateFormat) {
        this.dateFormat = dateFormat != null ? dateFormat :
                create(DEFAULT_LOCALE, DateFormat.DEFAULT, DateFormat.DEFAULT, 
null);
    }

So `DateFormat#create` isn't called and `setLenient` isn't called.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1880#discussion_r2543428225