On Fri, 21 Nov 2025 16:19:07 GMT, Andy Goryachev <[email protected]> wrote:

> A missing protected method in StyledTextModel prevents from toggling of an 
> individual paragraph attribute.
> 
> This can be tested with he latest Monkey Tester
> https://github.com/andy-goryachev-oracle/MonkeyTest
> 
> - select the RichTextArea page
> - select the RichTextArea model
> - select Control -> Context Menu -> RichTextArea menu
> - type in several paragraphs
> - select all and apply one paragraph attribute, let's say Paragraph Styles -> 
> Background -> (any non-null)
> - select a subset of previously selected paragraphs and apply a second 
> paragraph attribute, let's say Paragraph Styles -> Bullet -> (any non-null)

Other than a missing `@since` tag, this all looks good.

modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyledTextModel.java
 line 216:

> 214:      * @param index the paragraph index
> 215:      * @param paragraphAttrs the paragraph attributes
> 216:      * @throws UnsupportedOperationException if the model is not {@link 
> #isWritable() writable}

This method needs `@since 26`

-------------

PR Review: https://git.openjdk.org/jfx/pull/1980#pullrequestreview-3494061903
PR Review Comment: https://git.openjdk.org/jfx/pull/1980#discussion_r2550731997

Reply via email to