On Fri, 21 Nov 2025 21:48:34 GMT, Andy Goryachev <[email protected]> wrote:

>> Michael Strauß has updated the pull request incrementally with two 
>> additional commits since the last revision:
>> 
>>  - numeric overflow to infinity
>>  - refactor tests
>
> modules/javafx.graphics/src/test/java/test/com/sun/scenario/animation/LinearInterpolatorTest.java
>  line 41:
> 
>> 39:         try {
>> 40:             Field f = 
>> LinearInterpolator.class.getDeclaredField("controlPoints");
>> 41:             f.setAccessible(true);
> 
> should an Accessor be used instead?

I'm not a big fan of that because of its impact on the source code of the class 
(you know those comments: "package-private only for the sake of testing").

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1977#discussion_r2552859552

Reply via email to