On Thu, 27 Nov 2025 06:19:53 GMT, Ambarish Rapte <[email protected]> wrote:

>> The issue occurred because the skin marks the button cell as “empty” when 
>> the value becomes null.
>> With the fix clearing the ComboBox value re-shows the prompt text.
>> Tested using the code present in the bug.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ComboBoxListViewSkin.java
>  line 457:
> 
>> 455:             if (cell == null) return true;
>> 456: 
>> 457:             // JDK-8296653
> 
> We generally don't include the bug id. Please remove.

May be we can add a comment to explain the change.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1989#discussion_r2567603219

Reply via email to