On Mon, 1 Dec 2025 19:12:34 GMT, Andy Goryachev <[email protected]> wrote:
> Looks good.
>
> I've updated the standalone Monkey Tester to add a couple of layout scenarios
> to the GridPane page.
Thanks, GridPane is quite a useful layout, but if you want to hide a row or
column, it is a huge pain currently (unless you use hgap/vgap of 0) as you need
to physically renumber your rows/columns to collapse the extra gaps...
> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
> 2635:
>
>> 2633:
>> 2634: private void setMaxSize(int position, double size) {
>> 2635: singleSizes[position] = Math.max(singleSizes[position],
>> size);
>
> I don't know why github shows this as a change.
> Unused `setMultiSize()` has been removed which is ok.
It's confusing the start of the diff I think :)
> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
> 2640:
>
>> 2638: private Iterable<Entry<Interval, Double>> multiSizes() {
>> 2639: if (multiSizes == null) {
>> 2640: return Collections.emptyList();
>
> unrelated change, and probably gets inlined anyway.
Yeah, could remove, I just made the change because it was giving a raw type
warning.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1990#issuecomment-3599174832
PR Review Comment: https://git.openjdk.org/jfx/pull/1990#discussion_r2578892593
PR Review Comment: https://git.openjdk.org/jfx/pull/1990#discussion_r2578893765
