On Tue, 16 Dec 2025 09:05:04 GMT, Lukasz Kostyra <[email protected]> wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> create sampler states only once
>
> modules/javafx.graphics/src/main/native-prism-mtl/MetalContext.m line 239:
>
>> 237:
>> 238: - (void) create3DSamplerStates
>> 239: {
>
> I think we could add something here to skip re-creating the sampler
> descriptors. This can be called every time we switch to 3D (from
> `nSetDeviceParametersFor3D`) and that way we could optimize this transition a
> bit.
That's a good point.
Actually not just descriptors even the samplers states should be created only
once. Updated the code.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2005#discussion_r2622950228
