On Tue, 16 Dec 2025 16:44:54 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use CssParser.size() to parse sizes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaFeatures.java
> line 56:
>
>> 54: return switch (lowerCaseFeatureName) {
>> 55: // Discrete min-/max-features are just features in a range
>> context in disguise.
>> 56: case "min-width" ->
>> rangeQueryExpression(SizeQueryType.WIDTH, featureValue,
>
> very minor suggestion:
>
> case "min-width" ->
> rangeQueryExpression(SizeQueryType.WIDTH, featureValue,
> ComparisonOp.GREATER_OR_EQUAL.getExpressionSupplier());
I've moved the code more towards the front of the line, similarly to how it's
already done for the user-preference features later in the `switch`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1844#discussion_r2624579561
