When compiling JavaFX with Java 25, a new warning appears. This warning will 
result in a compilation failure because warnings are treated as error 
(`-Werror`).

The following warning appears:


> Task :controls:compileJava
C:..\jfx\modules\javafx.controls\src\main\java\javafx\scene\control\SplitPane.java:320:
 warning: [identity] use of a value-based class with an operation that expects 
reliable identity
    private final WeakHashMap<Integer, Double> dividerCache = new 
WeakHashMap<>();
                                                                             ^
C:..\jfx\modules\javafx.controls\src\main\java\javafx\scene\control\SplitPane.java:320:
 warning: [identity] use of a value-based class with an operation that expects 
reliable identity
    private final WeakHashMap<Integer, Double> dividerCache = new 
WeakHashMap<>();
                             ^
error: warnings found and -Werror specified
1 error
2 warnings

> Task :controls:compileJava FAILED


The warning makes sense: We use a `WeakHashMap` with the `Integer` class. So 
the `Integer` values are saved as `WeakRef` inside the `Map`. This makes no 
sense and is rightfully a warning.

-------------

Commit messages:
 - 8373885: Compilation failure due to a warning when compiling with Java 25

Changes: https://git.openjdk.org/jfx/pull/2010/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=2010&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8373885
  Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jfx/pull/2010.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2010/head:pull/2010

PR: https://git.openjdk.org/jfx/pull/2010

Reply via email to