On Wed, 17 Dec 2025 10:54:34 GMT, Marius Hanl <[email protected]> wrote:

>> This is a small improvement that was noted back in 
>> https://github.com/openjdk/jfx/pull/1200#issuecomment-1671954361 by @mstr2, 
>> and was on my list since then.
>> 
>> The idea is to have only one place for assigning `adapter ordinals` – within 
>> `Screen`. The corresponding setter `setAdapterOrdinal` can therefore be made 
>> private. This improves the separation of responsibilities a little. :-)
>
> Marius Hanl has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains two additional 
> commits since the last revision:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jfx into 
> 8314820-unify-screen-adapter
>  - 8314820: Unify Screen adapter ordinal logic

Looks good, quick local confidence check works fine.

-------------

Marked as reviewed by lkostyra (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2009#pullrequestreview-3588580232

Reply via email to