On Tue, 16 Dec 2025 18:24:32 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add more debug output > > Note: I am using the latest standalone monkey tester > https://github.com/andy-goryachev-oracle/MonkeyTest but a similar issue is > present in the one that's currently in the main repo. @andy-goryachev-oracle my first fix broke PopupWindow sizing code; it apparently relies on the scene being sized despite setting a fixed Window width/height. I feel that code is too intertwined to touch, so I decided to go for a different approach. **New approach:** Instead of using `applyBounds` to have the peer determine the correct screen output scales (but also updates many other values), I now have the Window code determine the correct Screen on its own. I then use the output scales of that Screen to set these values on the peer, but do not update the peer yet. The scene is then sized (as before) with the correct render scales in order to fix the ellipsis issue. The `applyBounds` call is then done in the usual location. So: - I can't `applyBounds` early because that breaks Mac as the size of the peer is no longer updated **after** the scene is sized to its preferred size, resulting in the Scene being shown with the wrong size - I can't skip the scene sizing when both dimensions on the Window are set explicitly because some PopupWindow tests (context menu tests) then fail, although I didn't see any adverse effects in a real application. I'm not entirely sure if that is a test bug (not realistic enough) or an actual bug. - And (the reason for this change) we also can't just use the primary's screen render scale when sizing the scene as otherwise ellipsis appear on labels in certain cases I think this new solution avoids many pitfalls, and is still a simple fix. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2007#issuecomment-3679106557
