On Tue, 23 Dec 2025 22:26:51 GMT, Alexander Matveev <[email protected]>
wrote:
>> modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioEqualizer.h
>> line 155:
>>
>>> 153:
>>> 154: void lockBands() {
>>> 155: pthread_mutex_lock(&mBandLock);
>>
>> I assume `int pthread_mutex_[lock|unlock]()` returns some kind of error
>> code. should we check it?
>
> Maybe. Other code we have does not check it.
> https://github.com/openjdk/jfx/blob/master/modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFAudioSpectrumUnit.h#L112
I checked documentation on when `int pthread_mutex_[lock|unlock]()` shall fail
and such conditions in our case are unlikely.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2008#discussion_r2644379707
