> The `HeaderBar` control currently has three areas: `leading`, `center`, and 
> `trailing`. Additionally, there's `leftSystemInset` and `rightSystemInset`, 
> which are not RTL adjusted. I've come to the understanding that there is no 
> particularly good reason for this, because every time you would want to use 
> this information for layout purposes, it should also be adjusted for RTL.
> 
> With this in mind, there are three changes for the `HeaderBar` control:
> 1. Rename `leading` to `left`, and `trailing` to `right`, which aligns the 
> terminology with `BorderPane`.
> 2. Adjust `leftSystemInset` and `rightSystemInset` for RTL.
> 3. Make `leftSystemInset`, `rightSystemInset`, and `minSystemHeight` attached 
> properties for `Stage`.
> 
> With this change, the `HeaderBar` control is more semantically consistent and 
> easier to use, and the renamed `left` and `right` areas now show its close 
> relationship with `BorderPane`.
> 
> In addition to that, two new `HeaderDragType` constants are added:
> * `TRANSPARENT`: when set on a node, excludes the node from draggable-area 
> hit testing
> * `TRANSPARENT_SUBTREE`: the same, but also applies to the node's subtree

Michael Strauß has updated the pull request incrementally with one additional 
commit since the last revision:

  Unspecified HeaderDragType is behind top resize border

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1936/files
  - new: https://git.openjdk.org/jfx/pull/1936/files/44c216bd..d0d16010

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1936&range=10
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1936&range=09-10

  Stats: 120 lines in 12 files changed: 67 ins; 5 del; 48 mod
  Patch: https://git.openjdk.org/jfx/pull/1936.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1936/head:pull/1936

PR: https://git.openjdk.org/jfx/pull/1936

Reply via email to