On Thu, 8 Jan 2026 16:32:56 GMT, Andy Goryachev <[email protected]> wrote:
>> Requesting `VFlow` re-layout when signaled by a `Node` embedded in >> `TextCell`. >> >> >> ### NOTES >> >> - this PR depends on https://github.com/openjdk/jfx/pull/1974 (resolved) >> - the fix can be verified visually using the latest standalone Monkey Tester >> https://github.com/andy-goryachev-oracle/MonkeyTest >> >> <img width="1232" height="741" alt="Screenshot 2025-11-17 at 13 43 12" >> src="https://github.com/user-attachments/assets/58b2ef77-094c-45bd-8a04-3caaa4672df1"; >> /> > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: > > 2026 Overall looks good to me, with one query and a comment in the discussion that @Maran23 had started about traversal in getAncestorOfClass(). modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/util/RichUtils.java line 767: > 765: } > 766: } > 767: return null; It seems this if condition would never be true in current situation, and very likely be never true in future in context of RTA. A VFlow cannot be Window. Can this code be removed ? keeping only the required else block. ------------- Changes requested by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/1975#pullrequestreview-3649236786 PR Review Comment: https://git.openjdk.org/jfx/pull/1975#discussion_r2680933790
