On Wed, 14 Jan 2026 21:57:14 GMT, Christopher Schnick <[email protected]> wrote:

>> This is a very basic solution to the OOBE described in the issue. While it 
>> would definitely be better to figure out the root cause, understanding the 
>> NGNode implementation is above my knowledge level atm.
>> 
>> The code has been like that for 10 years and no one complained, so I am not 
>> sure whether this is a deeper issue or just a small oversight when handling 
>> all possible cases.
>> 
>> The fix should retain the exact original workings of the method while 
>> avoiding the exception.
>
> Christopher Schnick has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Wrap expression in parentheses

modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGGroup.java line 
259:

> 257:                 NGNode child;
> 258:                 try {
> 259:                     child = orderedChildren.get(i);

You should remove the try-catch block as your change ensures that `List.get()` 
is never called with an invalid index.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2037#discussion_r2692494209

Reply via email to