On Wed, 21 Jan 2026 12:45:24 GMT, Christopher Schnick <[email protected]> wrote:
>> This should improve the code quality of the class while preserving its >> original workings > > Christopher Schnick has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unused field and not reachable code Ok there seems to be a bigger issue with this class here. As @mstr2 correctly pointed out, the blend mode setter is not used. Therefore, the blend more field always has the same value. I removed all the code which is essentially unreachable due to this fact. Right now, the NGGroup class does not apply any blend more settings from the NGNode blendMode field. Whether this causes issues, I'm not sure. It should though. That is at least the current state of the code. So either this PR can keep this direction of just going for an equivalent cleanup as of right now, and there might be another follow-up ticket for the blend mode issue. Or the blend mode issue can be covered by this PR as well. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2043#issuecomment-3777966122
