On Fri, 16 Jan 2026 18:39:03 GMT, Martin Fox <[email protected]> wrote:

>> Thiago Milczarek Sayao has updated the pull request with a new target base 
>> due to a merge or a rebase. The pull request now contains 85 commits:
>> 
>>  - Merge branch 'master' into 8354943
>>    
>>    # Conflicts:
>>    # tests/system/src/test/java/test/util/Util.java
>>  - Merge branch 'master' into 8354943
>>  - Remote assumeTrue for JDK-8364547
>>  - Merge branch 'master' into 8354943
>>  - Merge branch 'master' into 8354943
>>    
>>    # Conflicts:
>>    # modules/javafx.graphics/src/main/native-glass/gtk/glass_window_ime.cpp
>>  - Merge branch 'master' into 8354943
>>  - Fix copyright header
>>  - Revert "8367898: Skip StageFocusTest on Linux"
>>    
>>    This reverts commit c95cdcdc9cd8b3070e8076ea91234772d6a21331.
>>  - Merge branch 'master' into 8354943
>>  - Remove unused imports
>>  - ... and 75 more: https://git.openjdk.org/jfx/compare/6626e013...7e3c3205
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 190:
> 
>> 188: 
>> 189:     window_size.setOnChange([this](const Size& size) {
>> 190:         notify_window_resize(is_maximized()
> 
> There is a very minor bug here that's also present in the master branch. If 
> the size of a window is changed when it's iconified it can't be un-iconified. 
> This notification tells the Java Window that it has been restored even though 
> it's still iconified which confuses the bookkeeping.
> 
> This is an old bug so I would be fine if we just enter a bug report and push 
> the fix off to another PR. Unfortunately there's no way to write an automated 
> test. That would require adding a call to query the OS for the window's state 
> so we can compare it with the state the Java Window is tracking.

Good catch. I've fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2725682684

Reply via email to