On Thu, 19 Feb 2026 15:47:41 GMT, Andy Goryachev <[email protected]> wrote:

>> Issue:
>> This is a metal pipeline specific issue. When Metal API Validation is 
>> enabled an assertion is thrown due to invalid scissor rect being set. Please 
>> test the steps described in the ticket 
>> [JDK-8369348](https://bugs.openjdk.org/browse/JDK-8369348).
>> 
>> Cause:
>> MetalContext.setClipRect() method uses the negative x,y values and later 
>> performs a negative value check.
>> This results in a clip rect with a width and height being larger than rtt 
>> size.
>> 
>> Fix:
>> Moving the negative value check before first use of x and y variables.
>> Test is not included as, it requires manually enabling Metal API Validation 
>> i.e. METAL_DEVICE_WRAPPER_TYPE
>> 
>> Verification:
>> Verify the issue described in the 
>> [JDK-8369348](https://bugs.openjdk.org/browse/JDK-8369348).
>> Perform general sanity test.
>
> modules/javafx.graphics/src/main/native-prism-mtl/MetalContext.m line 600:
> 
>> 598: 
>> 599: - (void) setClipRect:(int)x y:(int)y width:(int)width height:(int)height
>> 600: {
> 
> do we need to update copyright year?

We can leave it to bulk copyright update change.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2078#discussion_r2832090425

Reply via email to