On Wed, 25 Feb 2026 20:41:24 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into feature/conditional-import
>> - Merge branch 'master' into feature/conditional-import
>> - Conditional stylesheet imports
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaQueryParser.java
> line 90:
>
>> 88: public MediaQueryList parseMediaQueryList(List<Token> tokens) {
>> 89: var stream = new TokenStream(tokens);
>> 90: var expressions = new MediaQueryList();
>
> minor complaint: we should probably limit the usage of 'var' keywords for
> tests. these are easier to write, I admit, but make the code harder to read.
I never use `var` when the type isn't visible, but when it's just a `new`
expression, I find them to be quite easy to read as it makes the variable name
stand out.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2031#discussion_r2856257861
