On Mon, 2 Feb 2026 23:09:58 GMT, Andy Goryachev <[email protected]> wrote:

>> Ziad El Midaoui has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Fix scrollbar issue
>
> Looks much better!
> 
> Two things:
> 1. please change the copyright year to 2026
> 2. noticed runLater() in `recomputePopupLayout()`, so I decided to apply CSS 
> to the popup.  You can use
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/bugs/ComboBox_PopupSize_8325564.java
> 
> On my primary retina display I get the scrollbars first time around.  The 
> scrollbars disappear on second showing:
> 
> <img width="310" height="391" alt="Screenshot 2026-02-02 at 15 05 29" 
> src="https://github.com/user-attachments/assets/ae5f149a-c845-4f5f-8ed6-5ffa404aed54";
>  />
> 
> 
> .combo-box-popup > .list-view {
>     -fx-padding: 100px
> }

@andy-goryachev-oracle Can I still review this?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2052#issuecomment-3993906389

Reply via email to