On Fri, 6 Mar 2026 19:54:10 GMT, Jose Pereda <[email protected]> wrote:

>> This PR adds a fix to prevent a crash on macOS after exiting full screen 
>> mode when a modal dialog is showing 
>> (https://bugs.openjdk.org/browse/JDK-8371370).
>> 
>> At the same time, it prevents non-resizable windows from entering full 
>> screen mode (https://bugs.openjdk.org/browse/JDK-8379315), given that the 
>> changes for both issues were interrelated.
>> 
>> While no tests have been added, manual tests have been run, checking that 
>> the style mask, the window behavior and the standard window buttons state, 
>> remained consistent in different scenarios.
>> 
>> Also, according to 
>> https://developer.apple.com/documentation/appkit/nswindow/showsresizeindicator,
>>  the `showsResizeIndicator` property has been removed.
>
> Jose Pereda has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix typo and remove unused property

This will need a lot of testing in various modes to ensure no regressions or 
unintended changes in behavior.

I did a fair bit of testing with an preliminary patch last year, but will need 
to refamiliarize myself with it.

@beldenfox Would you have time to take a look at this as well?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/2098#issuecomment-4013911605

Reply via email to