On Wed, 11 Mar 2026 13:06:00 GMT, Ziad El Midaoui <[email protected]> 
wrote:

>> The bug occurs when showRoot is set to false on a root with no children, the 
>> expanded item count drops is 0 causing `isFocused(0)` to return false even 
>> though `focusedIndex` is still 0. When items are added afterwards the 
>> `treeItemListener` sees `focusedIndex=0` and incorrectly shifts it to 1 
>> placing the focus on second item of the `TreeTableView`.
>> The fix replaces `isFocused(0)` with `getFocusedIndex() >= 0`, which reads 
>> the raw stored index.
>
> Ziad El Midaoui has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix TreeTableView initial focus

looks good with the reproducer (no item is selected as expected), no ill 
effects found in the monkey tester.

the test fails in master and passes with the fix.

modules/javafx.controls/src/main/java/javafx/scene/control/TreeTableView.java 
line 3667:

> 3665:                         // shift if the tree item is expanded
> 3666:                         TreeItem<S> eventTreeItem = e.getTreeItem();
> 3667:                         if (!treeTableView.isShowRoot()

please update the copyright year 2026

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2104#pullrequestreview-3932874448
PR Review Comment: https://git.openjdk.org/jfx/pull/2104#discussion_r2921289621

Reply via email to