On Sun, 15 Mar 2026 21:16:17 GMT, Marius Hanl <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge branch 'master' into feature/conditional-import
>>
>> # Conflicts:
>> # modules/javafx.graphics/src/main/java/javafx/css/CssParser.java
>> - javadoc change
>> - javadoc change
>> - specify capacity of MediaQueryList
>> - javadoc change
>> - Merge branch 'master' into feature/conditional-import
>> - Merge branch 'master' into feature/conditional-import
>> - Conditional stylesheet imports
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaFeatures.java
> line 45:
>
>> 43:
>> 44: // Extension point for unit tests to add media features
>> 45: public static BiFunction<String, Token, MediaQuery> DEFAULT =
>> (featureName, _) -> {
>
> So if I understand correctly, this is only needed for Unit tests? Is there
> any other way we can test this without having a `public static` variable?
The field could be private and the test could use reflection to access it, but
this class is an implementation detail, so I'm not sure if that's an advantage.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2031#discussion_r2937375805
