On Fri, 20 Mar 2026 01:25:15 GMT, Alexander Matveev <[email protected]> 
wrote:

> - Fixed potential NULL pointer dereference.
> - Tested on all platforms with all supported media files.

lgtm.  

@lukostyra could you be the second reviewer (this and related PRs)?

modules/javafx.media/src/main/native/gstreamer/gstreamer-lite/gstreamer/gst/gstvecdeque.c
 line 112:

> 110: 
> 111:   array = gst_vec_deque_new_for_struct (sizeof (gpointer), initial_size);
> 112: #ifdef GSTREAMER_LITE

Question: are all the callers of this method prepared to handle `NULL` ?
(here and in all other PRs)

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2115#pullrequestreview-3983360291
PR Review Comment: https://git.openjdk.org/jfx/pull/2115#discussion_r2967356415

Reply via email to