On Fri, 20 Mar 2026 20:40:59 GMT, Marius Hanl <[email protected]> wrote:
>> This PR cleans up the non alternative path of the `MouseEventFirer`. >> The code is unused, since the `alternative` mode is always true => the >> default. >> It was also not working correctly, so there really is no need to keep it. >> >> Introduced in: https://github.com/openjdk/jfx/pull/313 >> Default since: https://github.com/openjdk/jfx/pull/852#discussion_r935409172 > > Marius Hanl has updated the pull request incrementally with one additional > commit since the last revision: > > Remove now unused scene field modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/MouseEventFirerTest.java line 203: > 201: // ------------- parameterized in not/alternative mouseEvent creation > 202: > 203: private static Collection<Boolean> data() { L201-202 can also be removed (L182 in PR) modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/VirtualizedControlTestUtils.java line 56: > 54: ScrollBar scrollBar = getVerticalScrollBar(control); > 55: Region track = (Region) scrollBar.lookup(".track"); > 56: MouseEventFirer firer = new MouseEventFirer(track); we probably should update the copyright year where applicable... ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2119#discussion_r2968137944 PR Review Comment: https://git.openjdk.org/jfx/pull/2119#discussion_r2968140138
