On Tue, 24 Mar 2026 19:46:52 GMT, Andy Goryachev <[email protected]> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Improve behavior select signature, improve javadoc
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Cell.java line 374:
> 
>> 372:     /**
>> 373:      * Stops the edit operation of the cell.
>> 374:      * This method is called when another cell is edited or the focus 
>> changed.
> 
> called by whom?
> is it meant to be called by the application?
> can it be made `protected`?

Made it public as the other edit methods are as well. I adjusted the javadoc to 
make more clear, what it does and why. Probably needs some more fine tuning.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r2984743175

Reply via email to