On Tue, 24 Mar 2026 23:05:57 GMT, Andy Goryachev <[email protected]> wrote:
>> It will break things. I fixed it by handling error correctly. Not sure why I >> miss it initially. > > the compiler did not generate an error? what would it return, whatever > happened to be in EAX (or whatever register it uses)? `add_segment` did not have any return value. So, `return` is fine without value. Issue is that fix was aborting `add_segment` execution without telling caller code, that it did not finished what it needs to do. Caller will continue using segment after `add_segment` and I have no idea what would happen. I refixed it by introducing return value to `add_segment` and caller will fail as well if `add_segment` fails. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2121#discussion_r2984943593
