On Tue, 24 Mar 2026 16:18:33 GMT, Martin Fox <[email protected]> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow+Overrides.m
> line 342:
>
>> 340: // For non-auto-hide popups, jWindowNotifyClose fires
>> WINDOW_CLOSE_REQUEST,
>> 341: // and that calls hide() on the popup.
>> 342: if ([self->nsWindow isVisible]) {
>
> Should non-auto-hide popups be hidden? The spec doesn't talk about them much
> and I'm not sure what they're used for.
@beldenfox It should be fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2102#discussion_r2990456631
