On Sun, 29 Mar 2026 18:40:42 GMT, Marius Hanl <[email protected]> wrote:
>> Charlie Schlosser has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address comments; microoptimization: ensure that each position is checked
>> exactly once; more elaborate tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java
> line 4018:
>
>> 4016:
>> 4017: TableView<String> table = new TableView<>();
>> 4018: table.setItems(FXCollections.observableArrayList("b", "c",
>> "a"));
>
> The only thing I'm a bit afraid in this and the other test: We use a very
> small amount of items. I guess it is fine, but I still wonder if we should
> use a bit more. To be safe.
added a more elaborate test that results in multiple contiguous islands of
indices
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2131#discussion_r3019359761
