On Mon, 6 Apr 2026 19:46:41 GMT, Kevin Rushforth <[email protected]> wrote:
> We'll need to evaluate this approach vs that of #1789 and choose one or the > other. > > It is accurate to say that the main difference between the two approaches is > that PR #1789 replaces GtkWindow with GdkWindow whereas this PR sticks with > GtkWindow? What other differences will help guide the reviewers? With the introduction of #2025, a `GtkWindow` became required for the FileChooser. As a result, PR #1789 needed a relatively large change to work directly with the portal (with a fallback to the GTK FileChooser), enabling the use of a `GdkWindow` as the parent. By reverting to `GtkWindow` instead of `GdkWindow`, this additional FileChooser-related change is no longer necessary. Experience shows that such changes can introduce regressions. Since this PR preserves the use of `GtkWindow` and changes less, it is likely lower risk compared to #1789. A final conclusion depends on further testing of this PR. > Does this PR address the same set of issues that PR #1789 does? That one > lists 10 additional bugs as also being resolved by that PR. > At this time, the answer is likely yes, as all tests are passing on Ubuntu 24.04 with XWayland. I will follow up with additional validation and explicitly list the confirmed fixes. The decision between #1789 and this PR will ultimately depend on the outcome of these tests. > /reviewers 2 reviewers ------------- PR Comment: https://git.openjdk.org/jfx/pull/2139#issuecomment-4195282134
