On Mon, 13 Apr 2026 17:18:39 GMT, Marius Hanl <[email protected]> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/Toolkit.java line 
>> 228:
>> 
>>> 226:         }
>>> 227: 
>>> 228:         boolean printToolkit = verbose || userSpecifiedToolkit;
>> 
>> I might suggest to change L252 to use stdout instead:
>> 
>> `System.out.println("JavaFX: using " + forcedToolkit);`
>> 
>> (I don't know why this is needed in the first place, but ok)
>
> I don't know either.
> 
> But is this something we should change in this PR?
> I mean for me, this is fine!
> I just don't know if there could be any consequences/If it needs some kind of 
> discussion

It makes the test log cleaner by removing the word "ERROR":


HeaderButtonOverlayTest > maximizeButtonIsDisabledWhenStageIsNotResizable() 
STANDARD_ERROR


We still see the output.  And it **is** a related change ;-)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2146#discussion_r3074730869

Reply via email to