On Sun, 29 Mar 2026 20:03:44 GMT, Philemon Hilscher <[email protected]> wrote:
>> This fixes the issue adressed here >> https://bugs.openjdk.org/browse/JDK-8222454 >> >> The added TreeTableViewTests were failing without the main code changes. I >> added the other tests to ensure the consistent functionality of related cell >> based components. >> The method getItemCount() needed to be moved to CellBehaviorBase to do the >> necessary index check in doSelect() below. All subclasses now implement this >> method based on the cell container. >> >> There is still some refactoring potential here, to reduce code duplications >> and ensure consistent behavior of all cell based components. This could be >> done in a follow-up PR. > > Philemon Hilscher has updated the pull request incrementally with one > additional commit since the last revision: > > 8222454: Review fixes > > Signed-off-by: Philemon Hilscher <[email protected]> Reviewers: @andy-goryachev-oracle some preliminary comments, this PR also needs `/template append` and ai policy acceptance. please merge the latest master branch. modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ListCellBehavior.java line 54: > 52: > 53: /** {@inheritDoc} */ > 54: @Override protected int getItemCount() { please place annotations on it's own line in the new code modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TableRowBehavior.java line 56: > 54: > 55: /** {@inheritDoc} */ > 56: @Override protected int getItemCount() { same here ------------- PR Review: https://git.openjdk.org/jfx/pull/2129#pullrequestreview-4109099550 PR Comment: https://git.openjdk.org/jfx/pull/2129#issuecomment-4247084140 PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r3082400613 PR Review Comment: https://git.openjdk.org/jfx/pull/2129#discussion_r3082410147
