On Tue, 14 Apr 2026 23:36:54 GMT, Jose Pereda <[email protected]> wrote:
> Technically, we could use an osascript like in the manual test > MacOSSystemenuTestBase (see `getMenuReaderProcess`) to find the About > position. But then the whole test, which was added to verify that the > spotlight field was inserted when a "Help" menu was added to the system menu > bar, could be solved just with this script. > > So this test should probably be indeed moved to a manual test, with the sole > purpose of visually confirming that the Spotlight is added under a "Help" > menu, and optionally, use the osascript to verify it. Keeping it as a system > test with the changes from this PR will always pass, so I don't see that much > value for the test. Well, the test file contains two tests that verify different aspects of the system menu bar behavior on macOS. Overall it still looks useful and I would prefer to keep it with the proposed changes unless there are objections. As for verifying that the Spotlight field is added under the "Help" menu, I will file a new bug to introduce a separate manual test for that purpose. ------------- PR Comment: https://git.openjdk.org/jfx/pull/2147#issuecomment-4252587337
