On Tue, 14 Apr 2026 21:05:04 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add exports
>
> modules/jfx.incubator.richtext/src/main/java/jfx/incubator/scene/control/richtext/model/StyleAttribute.java
> line 113:
>
>> 111: * @since 27
>> 112: */
>> 113: public boolean isCharacterAttribute() {
>
> Have you considered a 3-valued enum for attribute type rather than 3 separate
> boolean attributes, which are mutually exclusive?
No, this would be a wrong pattern.
Here, `isXXX()` indicates a trait, which may or may not map exactly to the
type, and we certainly don't want the callers to write `if(getType ==
SOMETIME)`, but rather write `if(isXXX())`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1800#discussion_r3089270455
