On Sat, 2 May 2026 16:59:54 GMT, Michael Strauß <[email protected]> wrote:
> This is why, when you give the overflow-menu factory an API, you should also > give the default factory an API element. Treating `null` as a toggle for an > actual factory implementation is just not a good choice, and we shouldn't do > that. Makes sense and I agree. This should follow the pattern we already have in e.g. `TableColumn`: https://github.com/openjdk/jfx/blob/697a534bf494d82bf8e0ecacfebaba003dcc6c7a/modules/javafx.controls/src/main/java/javafx/scene/control/TableColumn.java#L202-L211 Note: There is also this pattern we have in JavaFX: https://github.com/openjdk/jfx/blob/697a534bf494d82bf8e0ecacfebaba003dcc6c7a/modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableViewSkin.java#L208-L216 which is similar to what Andy did. But a default factory in our case makes more sense. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1773#issuecomment-4367123248
