On Wed, 6 May 2026 19:35:35 GMT, Andy Goryachev <[email protected]> wrote:
>> Christopher Schnick has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update javadocs
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ComboBox.java line
> 325:
>
>> 323: *
>> 324: * When the ComboBox is {@link #editableProperty() editable}), the
>> converter is used
>> 325: * to convert the input to an object of type T, such that the input
>> may be retrieved
>
> I like the new javadoc very much, thank you!
>
> the only nitpick is "the converter is used to convert", can it be re-phrased?
I thought about, but something like mapped or transformed might not be the best
either
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java
> line 338:
>
>> 336: }
>> 337:
>> 338: @Test public void testCellUpdateOnStringConverterChange() {
>
> could you move the `@Test` annotation to its own line here and L363 please?
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2165#discussion_r3202424160
PR Review Comment: https://git.openjdk.org/jfx/pull/2165#discussion_r3202425645
