On Mon, 11 May 2026 17:58:09 GMT, Christopher Schnick <[email protected]> wrote:
>> This PR adds a missing call to update the display value to the converter >> property listener >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Christopher Schnick has updated the pull request incrementally with one > additional commit since the last revision: > > Call refresh() Looks good, and thank you for adding the tests! Somewhat related, I tried to set a null converter, and that broke the monkey tester. There is nothing in the API spec that talks about nullability of this property, but I would expect that setting it to `null` should be equivalent to choosing the default converter ( `ComboBox.<T>defaultStringConverter()` , ComboBox:332 ) What do you guys think? If you think we should allow a `null` converter, I can file a new RFE and add it under https://bugs.openjdk.org/browse/JDK-8334883 ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2165#pullrequestreview-4267923556
