On Tue, 28 Apr 2026 15:33:27 GMT, Ziad El Midaoui <[email protected]> wrote:
>> Added Test to check caret visibility in `TextField` and dead space at >> beginning/end of text. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Fixed Widths change LGTM. tests/system/src/test/java/test/robot/javafx/scene/TextFieldCaretVisibilityTest.java line 49: > 47: private static final double MARGIN = 2.0; > 48: > 49: private static final double[] TEST_WIDTHS = { 600, 50 }; A minor observation, the width of stage in RobotTestBase class is 400. So, the TEST_WIDTHS=600 won't really get applied to TF. The size of TextField gets restricted to 400, which seems ok as a test. ------------- Marked as reviewed by arapte (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2157#pullrequestreview-4274081509 PR Review Comment: https://git.openjdk.org/jfx/pull/2157#discussion_r3227945852
