On Tue, 12 May 2026 17:25:47 GMT, Andy Goryachev <[email protected]> wrote:
>> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> - Fix issue where VoiceOver treats non-editable text element as editable. >> Both ways of shielding setters and an old style selector returning if >> value is settable are required to work on all supported macOS versions. > > modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line > 149: > >> 147: jobject jresult = (jobject)(*env)->CallLongMethod(env, [self >> getJAccessible], >> 148: >> jAccessibilityAttributeValueForParameter, >> 149: (jlong)attribute, >> (jlong)parameter); > > very minor: parameter alignment. > > The coding style calls for aligning wrapped parameters on the first one, but > I don't like this idea at all: one refactoring and the alignment is out of > whack. > > What I would propose to do is to offset by one tab (four spaces), and also > place each parameter on its own line: > > > jobject jresult = (jobject)(*env)->CallLongMethod( > env, > [self getJAccessible], > jAccessibilityAttributeValueForParameter, > (jlong)attribute, > (jlong)parameter); > > > (one hidden benefit of this style is that one can add comment to individual > arguments) > > Having said all this, the current indentation is also acceptable to me. Noted. I will change cosmetic issues in the upcoming pull requests for TableAccessibility. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3229549527
