On Fri, 15 May 2026 09:47:23 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/Cell.java line
>> 360:
>>
>>> 358: */
>>> 359: focusedProperty().addListener(_ -> {
>>> 360: pseudoClassStateChanged(PSEUDO_CLASS_FOCUSED,
>>> isFocused()); // TODO is this necessary??
>>
>> is this comment _still_ necessary?
>
> I think `pseudoClassStateChanged` is not necessary here. Maybe I will file a
> bug and create a simple PR for that, good point.
Not sure I understand your response: the code that toggles PSEUDO_CLASS_FOCUSED
is likely to be necessary (it's a private constant, and this is the only spot
it's referenced from).
The `comment` does not seem to be needed.
Or am I completely off the mark here?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r3249786013
