> - Removed/disabled coded which uses `gunichartables.h`. We do not use it and 
> do not need.
> - Only dependency on this code is `GVariant` which uses `g_unichar_isprint` 
> to determine if character can be printed or needs to be escaped. This code is 
> not being used currently, but might be in the future. Assert which validates 
> `GVariant` string uses it to log value of `GVariant` in case if assert fails. 
> We might need it someday, so I keep it. Code was updated to use if ascii is 
> printable instead, since we do not use any unicode in our code. In worst case 
> we will escape non-ascii characters in debug log.
> - I tested on all platforms with all supported formats.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Alexander Matveev has updated the pull request incrementally with one 
additional commit since the last revision:

  8379561: Remove UNICODE related code from GLib [v5]

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2168/files
  - new: https://git.openjdk.org/jfx/pull/2168/files/e3663823..4dff1146

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2168&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2168&range=00-01

  Stats: 7 lines in 3 files changed: 1 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/2168.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2168/head:pull/2168

PR: https://git.openjdk.org/jfx/pull/2168

Reply via email to