On Wed, 20 May 2026 05:19:36 GMT, Christopher Schnick <[email protected]> 
wrote:

>> This is a follow-up to the combobox converter PR. It seems like the 
>> updateDisplayNode method in the Skin does not properly handle null cases for 
>> when null is an item in the combobox. It probably incorrectly assumes that 
>> any null values is mapped to null by the stringconverter. However, if you 
>> create a custom converter, a null value can have a non-null string value.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Christopher Schnick has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix null handling for text field

Looks good now, thanks!

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2169#pullrequestreview-4331663416

Reply via email to