On Wed, 20 May 2026 22:02:37 GMT, Andy Goryachev <[email protected]> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> verify that malformed queries evaluate to false
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/media/MediaQueryParser.java
> line 98:
>
>> 96: Token comma = stream.consume();
>> 97: if (expectMediaCondition || expressions.isEmpty()) {
>> 98: errorHandler.accept(comma, "Unexpected token");
>
> would it make sense to test this failure path, and also in L134 for
> completeness sake?
Yes that makes sense. I've added tests for all failure paths where the media
query list is malformed. Now we consistently apply the rule that a malformed
query evaluates to false, but doesn't stop the parser.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2162#discussion_r3279562901
