On Thu, 28 May 2026 06:29:13 GMT, Marius Hanl <[email protected]> wrote:

>> The `Cell` registers a listener to the `focusedProperty`.
>> In the listener the `focused` `PseudoClass` is set or unset depending on the 
>> state of the `focusedProperty` (true/false).
>> Followed by a TODO, stating: `TODO is this necessary??`
>> 
>> The answer is no, this is unnecessary and already done by `Node`.
>> The `focusedProperty` will set or unset the "focused" `PseudoClass` in the 
>> same way that is done in `Cell`.
>> 
>> Mentioned first in this comment  
>> https://github.com/openjdk/jfx/pull/1935#discussion_r3243531543
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Marius Hanl has refreshed the contents of this pull request, and previous 
> commits have been removed. The incremental views will show differences 
> compared to the previous content of the PR. The pull request contains one new 
> commit since the last revision:
> 
>   8385533: Cell "focused" PseudoClass handling is unnecessary

the test passes in master, as expected, confirming that the removed code is 
unnecessary.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2176#pullrequestreview-4404301492

Reply via email to