On Tue, 26 May 2026 21:48:27 GMT, Marius Hanl <[email protected]> wrote:
> This replaces all `JNI_VERSION` version strings with `JNI_VERSION_1_8`.
> All of JavaFX is `JNI_VERSION_1_8` now.
>
> - Tested with JLink+JPackage (with and without JMods)
> - Tested with GraalVM (newest version 25)
>
> Sometimes this allowed to replace code that was always built like this:
>
>
> #ifdef JNI_VERSION_1_8
> //min. returned JNI_VERSION required by JDK8 for builtin libraries
> JNIEnv *env;
> if ((*vm)->GetEnv(vm, (void **)&env, JNI_VERSION_1_8) != JNI_OK) {
> return JNI_VERSION_1_4;
> }
> ...
>
>
> with:
>
> return JNI_VERSION_1_8;
>
>
> **Question -> Will do as Follow-up**
>
> ~There are a few locations where we have the following pattern;~
>
> if (jvm->GetEnv((void **)&env, JNI_VERSION_1_8)) {
> return JNI_ERR; /* JNI version not supported */
> }
>
> ~which should not happen anymore, right?
> Most of the code locations do not have this check and just do:~
>
> jvm->GetEnv(&env, JNI_VERSION_1_8);
>
> ~Should I follow that pattern for the few locations left?~
>
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK
> Interim AI Policy](https://openjdk.org/legal/ai).
Will create a follow-up task and assign it to me - so we can make this change
first, which should be uncontroversial, and then I'll implement the `env`
simplification and write in the mailing list again. Especially regarding the
Android and Web env changes, I'd at least prefer to make sure this is fine for
Gluon as well.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2175#issuecomment-4615114439
