On Fri, 12 Jun 2026 14:36:30 GMT, John Hendrikx <[email protected]> wrote:
>> This PR fixes the computeSize methods not considering the gap in some cases. >> >> It also fixes a missed spot, in the previous PR for JDK-8092379. >> >> Each fix is covered by simple tests which fail before and work after the >> change. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line > 1817: > >> 1815: for (int j = c + 1; j < cs + c; >> j++) { >> 1816: w += widths.hasGapBefore(j) ? >> snaphgap : 0; >> 1817: w += widths.getSize(j); > > This was the spot I missed in JDK-8092379 I guess? :) Yes. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2187#discussion_r3404139387
