On Tue, 16 Jun 2026 20:58:34 GMT, Kevin Rushforth <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 194 commits: >> >> - test standard attributes >> - Merge branch 'master' into 8356042.ruler >> - ws >> - test doc props >> - cleanup >> - tab stops >> - Merge branch 'master' into 8356042.ruler >> - renamed doc >> - docs >> - Merge branch 'master' into 8356042.ruler >> - ... and 184 more: https://git.openjdk.org/jfx/compare/738be0f1...87241d12 > > modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/control/richtext/Converters.java > line 203: > >> 201: private static TabStops toTabStops(String text) { >> 202: if (text.length() == 0) { >> 203: return null; > > An empty list might be cleaner unless there is a need for `null` (e.g., if > `null` is logically distinct from an empty list). no, in this case we rely on `null` being returned. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1800#discussion_r3424270227
