Before joining JFX I worked a lot using a Gerrit code review system, where to mark the comment as done you would have a short-hand "Reply with Done" button. On one hand it marks the comment as seen and acted upon, on the other it leaves the conversation up to let the reviewers come back to it. I adopted a similar approach here, when fixing I simply comment "Done" or "Fixed" leaving the conversation resolution to the comment's authors so they can double-check that their suggestion was in fact done correctly. There are only very select minor situations which are trivially resolved (ex. unused imports to remove) where I directly resolve a conversation without commenting and leaving it to the reviewer.
That said, I don't think we have a direct guideline about this. If I were to suggest one, it would be the above, either with commenting "Done" or with a thumbs-up reaction. The commenters should be the ones resolving the conversations they started. > a checkmark icon would have been better, but I don't know how to do that. Since GitHub added reactions (in 2019 I think?) they preselected the ones we now available and never really came back to them, so at this point in time it's impossible to pick other icons/emojis. -Lukasz -----Original Message----- From: Andy Goryachev <[email protected]> Sent: Monday, 22 June 2026 16:29 To: Thiago Milczarek Sayão <[email protected]>; openjfx-dev <[email protected]> Subject: Re: [External] : Question about resolving GitHub review conversations I think it's a bug^H^H^H "feature" in github UI - only the commenter should be able to "resolve" a conversation. But I found that resolving and collapsing the conversation is somewhat counterproductive, since other reviewers might want to see it. I've been adding an upvote reaction once the particular concern has been addressed - a checkmark icon would have been better, but I don't know how to do that. -andy From: Thiago Milczarek Sayão <[email protected]> Date: Monday, June 22, 2026 at 03:46 To: openjfx-dev <[email protected]> Subject: [External] : Question about resolving GitHub review conversations Hi all, I have a question about the OpenJFX review workflow. When a reviewer leaves a comment on a GitHub PR and the author makes the requested changes, is there a preferred convention for resolving the conversation? Should the author mark it as resolved after addressing the comment, or should it be left for the reviewer to resolve after verification? Thanks.
