On Fri, 26 Jun 2026 16:31:17 GMT, Nir Lisker <[email protected]> wrote:
>> the proposed code is no different? in any case, throwing an NPE might be >> better in this case. > > I'm proposing to remove this since the `null` check in `ids` was done with > `Set.of(ids)`. It's unreachable code (unless `ids` is changed in a background > thread maybe, but I don't think this is a real concern, and you can work with > `identifier` instead anyway). I agree (I think I got confused by the github diff in the conversation). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2197#discussion_r3483323294
