On Mon, 29 Jun 2026 17:18:45 GMT, Ziad El Midaoui <[email protected]> wrote:
>> This fixes a `TextInputControl` styling issue where prompt text is hidden >> when an empty text input control receives focus. >> The fix removes the focused-state override `-fx-prompt-text-fill: >> transparent;` so focused empty text inputs continue to use the normal Modena >> prompt text fill. >> The prompt text now stay visible when a text input control is focused. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request incrementally with two > additional commits since the last revision: > > - Minor end of file space issue > - Added Copyright header to TextInputControlCaspianTest Left a minor suggestion, but this lgtm as is. modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/TextInputControlModenaTest.java line 77: > 75: public void setup() { > 76: userAgentStylesheet = Application.getUserAgentStylesheet(); > 77: Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA); we could probably do this in `@BeforeClass`, but it does not matter (much), only makes the test run slightly longer. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2184#pullrequestreview-4594205772 PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3493723067
